Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Forge Data Decoder #578

Merged
merged 72 commits into from
Feb 7, 2024
Merged

Conversation

CoolCat467
Copy link
Contributor

Follow up to #555, this PR implements a forge data decoder.

Copy link
Member

@PerchunPak PerchunPak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick look, will continue when you will fix the CI. But I am happy that this feature finally will be added to mcstatus!

mcstatus/forge_data.py Outdated Show resolved Hide resolved
mcstatus/forge_data.py Outdated Show resolved Hide resolved
mcstatus/forge_data.py Outdated Show resolved Hide resolved
mcstatus/forge_data.py Outdated Show resolved Hide resolved
mcstatus/forge_data.py Outdated Show resolved Hide resolved
mcstatus/status_response.py Show resolved Hide resolved
tests/status_response/test_java.py Outdated Show resolved Hide resolved
tests/status_response/test_java.py Outdated Show resolved Hide resolved
tests/status_response/test_java.py Outdated Show resolved Hide resolved
tests/test_forge_data.py Outdated Show resolved Hide resolved
Copy link
Member

@PerchunPak PerchunPak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more fast review, some later will dig into the protocol and the algorithm.

mcstatus/forge_data.py Outdated Show resolved Hide resolved
mcstatus/forge_data.py Outdated Show resolved Hide resolved
mcstatus/forge_data.py Outdated Show resolved Hide resolved
mcstatus/forge_data.py Outdated Show resolved Hide resolved
mcstatus/forge_data.py Outdated Show resolved Hide resolved
mcstatus/forge_data.py Outdated Show resolved Hide resolved
mcstatus/forge_data.py Outdated Show resolved Hide resolved
tests/test_forge_data.py Outdated Show resolved Hide resolved
mcstatus/forge_data.py Outdated Show resolved Hide resolved
@CoolCat467
Copy link
Contributor Author

I thought this was done a long time ago, kind of forgot it was still open.

@CoolCat467
Copy link
Contributor Author

CoolCat467 commented Dec 12, 2023

Oh, have we changed the test system? Everything was working earlier. If I could get help converting to whatever the new system is that would be great.
Fixed with 4d10d66

@PerchunPak
Copy link
Member

So could you answer open conversations? As far as I can remember, it's almost ready for merge, except for those two things.

Copy link
Member

@PerchunPak PerchunPak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't expect to find this amount of things to improve, but it's almost ready.

mcstatus/forge_data.py Outdated Show resolved Hide resolved
mcstatus/forge_data.py Outdated Show resolved Hide resolved
mcstatus/motd/__init__.py Outdated Show resolved Hide resolved
mcstatus/motd/__init__.py Outdated Show resolved Hide resolved
mcstatus/status_response.py Show resolved Hide resolved
tests/status_response/test_java.py Outdated Show resolved Hide resolved
tests/status_response/test_java.py Outdated Show resolved Hide resolved
tests/status_response/test_java.py Outdated Show resolved Hide resolved
tests/status_response/test_java.py Outdated Show resolved Hide resolved
tests/status_response/test_java.py Outdated Show resolved Hide resolved
@PerchunPak
Copy link
Member

I think it would be easier if I will just commit those changes, that I proposed in review. Of course if you don't mind

@CoolCat467
Copy link
Contributor Author

I think it would be easier if I will just commit those changes, that I proposed in review. Of course if you don't mind

Sure thing, I would like to see these changes merged in one way or another so I don't need to maintain my own module to do it because of lack of support.

@PerchunPak
Copy link
Member

I honestly forgot what I wanted to do here and how this code works. Fixed only what I wrote about in last review.

Copy link
Member

@ItsDrike ItsDrike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been a while, let's merge it!

@PerchunPak PerchunPak merged commit 18a33e8 into py-mine:master Feb 7, 2024
9 checks passed
@CoolCat467 CoolCat467 deleted the forge-data branch February 8, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: API Related to core API of the project type: feature New request or feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants